Issue a warning when a parameter is not consumed by a task #3170
Conversation
adrien-berchet
force-pushed
the
unconsumed_param_warning
branch
from
ca8fed1
to
03036d5
Compare
|
With pleasure :-) Do you know when the next release is planned? The last one is pretty old and there are several things in the master branch we are interested in. |
|
@adrien-berchet , the current release is quite old. I haven't done a Luigi release myself in years, but I can try to get one out. If so, it'll likely be 3.1.0. Out of curiosity, are y'all currently using |
|
Ah cool, that would be great, thanks! Currently we use the 3.0.3. But we have a repository (https://github.com/BlueBrain/luigi-tools) in which we add everything we need and then we submit PRs here for the generic features that might be interesting for others. |
|
I've gotten the release started at #3171 I'll have to get a Spotify employee to approve the version bump before i can merge. At that point, i'll proceed with updating PyPi (hopefully i still have access to do so). |
|
Ok, thank you very much! |
Description
After consuming the parameters I add a check to ensure that the task consumed all given parameters. If it is not the case a warning is raised.
Motivation and Context
In one of our workflows, several tasks have similar parameters but not all. This confused some users that tried to use such parameter with irrelevant tasks and the users were confused. Adding warnings could help users to understand what's happening. It can also help finding typos in parameter names (if they have a default value
luigidoes not complain and just use the default value).Have you tested this? If so, how?
I added a unit test.